Darwinbots Forum

Code center => Suggestions => Topic started by: Botsareus on October 28, 2005, 03:52:12 PM

Title: What is wrong with Numgils new plasment control?
Post by: Botsareus on October 28, 2005, 03:52:12 PM
A. ) No circler plasment

B.) Using the "frame" instead of a "picture box" , bad look.

C.) No "optional" keep in place "keep plasment", probebly still reporduces only the one veg from the list.

D.) Very funny Num, Now you can draw the rectangle outside the limits of the screen.

E.) only 4 point, not 8 point selection.

F.) Did I mention: No Drag-n-draw plasment?

Why I am doing this? simple, the logic above states that I will never code for DB again, do what ever you want from now on.

This world is not my frand. Num is the only one who will be getting a nobel for DB. Everyone else is just sheep.
Title: What is wrong with Numgils new plasment control?
Post by: Botsareus on October 28, 2005, 03:54:55 PM
Yes Num , the plasment control you wrote from scrach is WAY better then mine. Thanks for your time too.
Title: What is wrong with Numgils new plasment control?
Post by: Botsareus on October 28, 2005, 03:57:04 PM
Boing lost the compatition.... Skunk works won...
Title: What is wrong with Numgils new plasment control?
Post by: Botsareus on October 28, 2005, 03:58:24 PM
So cruel world , tell me why I should still be here...
Title: What is wrong with Numgils new plasment control?
Post by: Numsgil on October 28, 2005, 03:58:54 PM
Sarcasm aside, I like mine (minus the missing feature or two) better.

8 points of selection looks sloppy.

Mine doesn't wiggle when you drag it (or flicker, or whatever you want to call it).

And I prefer dragging the existing box instead of creating a new one when you click outside the box.

It's all bounds checked when the control loses focus.

I don't know what you mean by C.

And I can read this code and make sense of it ;)
Title: What is wrong with Numgils new plasment control?
Post by: Botsareus on October 28, 2005, 04:13:05 PM
Quote
8 points of selection looks sloppy.
First time I use windows I thought it was the most redicules disorganized peace of crap I ever seen. But its comfort that counts.

Quote
Mine doesn't wiggle when you drag it (or flicker, or whatever you want to call it).
Thats nice, mine is not supposed to do that eather.

Quote
And I prefer dragging the existing box instead of creating a new one when you click outside the box.
I agree , if you never actualy use the robot plasment, there is no point of making it other then your own "preferable" way.

Quote
It's all bounds checked when the control loses focus.
Quote
D.) Very funny Num, Now you can draw the rectangle outside the limits of the screen.
Yes this is WAY better then my , your logic is undiniable.

Quote
I don't know what you mean by C.
No "optional" keep in place "keep plasment", Girz does not care , I dont care.
(probebly still reporduces only the one veg from the list.)/RANT 'see my comments in code "aha gotea" one , stolen from my math teacher test results 53% one.


Quote
And I can read this code and make sense of it
I can't read your code , or make sense of it at times... thank god its open source.
(were is the logic, num knew no vb he is just being a #%$%# thats were the logic is. Can't beat solid cr quitable logic.)

Quote
A. ) No circler plasment
No answer. Yes Num likes his work , I bet. Who does not?

Quote
B.) Using the "frame" instead of a "picture box" , bad look.
followed by a no answer followed by "looks sloppy" , unidniable logic, end of story.
Title: What is wrong with Numgils new plasment control?
Post by: Botsareus on October 28, 2005, 04:14:13 PM
Tell me why I am still here...
Title: What is wrong with Numgils new plasment control?
Post by: Numsgil on October 28, 2005, 04:17:08 PM
It's all going to be rewritten into C++ anyway, so I didn't want to spend alot of time on it.  The new one for 2.4 is better than the old one,  may or may not be better than yours.  Either way it all gets rewritten.
Title: What is wrong with Numgils new plasment control?
Post by: Botsareus on October 28, 2005, 04:27:06 PM
Quote
It's all going to be rewritten into C++ anyway, so I didn't want to spend alot of time on it. The new one for 2.4 is better than the old one, may or may not be better than yours. Either way it all gets rewritten.

IT WAS EASYER FOR YOU TO ADD MY THEN MAKE YOUR OWN. thats were the logic horificaly brakes down so much, that offereing a solution to the argument without retaining to cosmic rift methods is higly impossible.

WHY DID NUM ADD HIS? HE DOES NOT GIVE A F&&& ABOUT MY WORK. I AM WASTING TYPE FOR 2 YEARS ALREADY AND I JUST FAIL TO SEE THIS.

Quote
may or [you]may not [/you]be better than yours.
Below is provided how it is better then yours num, you still have to prove me wrong on it

Quote
Quote
8 points of selection looks sloppy.
First time I use windows I thought it was the most redicules disorganized peace of crap I ever seen. But its comfort that counts.
Num attempted an explonation that had nothing to do with the problem, I still don't buy it.

Quote
Quote
Mine doesn't wiggle when you drag it (or flicker, or whatever you want to call it).
Thats nice, mine is not supposed to do that eather.
Num attempted an explonation that had nothing to do with the problem, I still don't buy it.


Quote
Quote
And I prefer dragging the existing box instead of creating a new one when you click outside the box.
I agree , if you never actualy use the robot plasment, there is no point of making it other then your own "preferable" way.
Num attempted an explonation that had nothing to do with the problem, I still don't buy it.


Quote
Quote
It's all bounds checked when the control loses focus.
Quote
D.) Very funny Num, Now you can draw the rectangle outside the limits of the screen.
Yes this is WAY better then my , your logic is undiniable.
Num attempted an explonation that had nothing to do with the problem, I still don't buy it.


Quote
Quote
I don't know what you mean by C.
No "optional" keep in place "keep plasment", Girz does not care , I dont care.
(probebly still reporduces only the one veg from the list.)/RANT 'see my comments in code "aha gotea" one , stolen from my math teacher test results 53% one.
Num attempted an explonation that had nothing to do with the problem, I still don't buy it.



Quote
Quote
And I can read this code and make sense of it
I can't read your code , or make sense of it at times... thank god its open source.
(were is the logic, num knew no vb he is just being a #%$%# thats were the logic is. Can't beat solid cr quitable logic.)
Num attempted an explonation that had nothing to do with the problem, I still don't buy it.


Quote
Quote
A. ) No circler plasment
No answer. Yes Num likes his work , I bet. Who does not?
Num attempted an explonation that had nothing to do with the problem, I still don't buy it.

Quote
Quote
B.) Using the "frame" instead of a "picture box" , bad look.
followed by a no answer followed by "looks sloppy" , unidniable logic, end of story.
Num attempted an explonation that had nothing to do with the problem, I still don't buy it.
Title: What is wrong with Numgils new plasment control?
Post by: Botsareus on October 28, 2005, 04:35:57 PM
Now now cruel world, tell me why I should be here, try to reasure me the way you reasure your "girlfrand" when you are cheating on your wife "that soon , soon I will leave my wife". After 3 times I asked for it it still did not get added.

BIG MISTAKE: MAKE THIS FOURM NOT THE SAME AS SONYS WERE I CANT USE QUOTES.
Title: What is wrong with Numgils new plasment control?
Post by: Numsgil on October 28, 2005, 05:17:31 PM
Um, chill pill   :rolleyes:

Your code is horrifically written, and I challenge you to find any coding veteran that will say otherwise.

I don't like to copy and paste code, I like to see how it works as I go.

So isntead I went and found a tutorial for something similar to what I wanted, and used that.  Said tutorial made sense from start to end.
Title: What is wrong with Numgils new plasment control?
Post by: Botsareus on October 28, 2005, 05:35:15 PM
OMG, But it is NOT HARD to copy and paste code when you have windiff.

It WAS NOT about HA! I CAN NOT READ YOUR CODE , THERE FOR I DON'T ADD IT. because you could of just asked me.



so what are you planning to do now wise guy? (sorry carl.)



adding the code was easy, . . .


I swear I was about to go and upload a new banner... lets see if this can be resolved.


What really is troubeling is you said you will add my code and you never did.
YOU COULD OF ADDED CODE YOU WANTED ANY TIME YOU WANT, YOU COULD OF EVEN TALKED TO ME ABOUT YOUR CODE, SO I COULD OF WROTE A COMPROMISE VIRSION. BUT IN REALITY THERE IS NOTHING TO COMPROMISE ABOUT, lets review:

Drag instead of Draw - sux
Move box outside screen - sux
Resize box outside screen -sux
No 8 point selection - sux
No clear indicators were the boarders of the plasment is (is it were the blue squars end , or when the gray nightmear ends) -sux (It is supposed to be messured by the middle of each blue square)

BLUE SQUARS ARE NICE N BIG -sux
Not to mention all the new features...

This thing goes litteraly agenst everything I had in mind. And then you call me a pill and say I should not act like I know you done that on purpose?
Title: What is wrong with Numgils new plasment control?
Post by: Numsgil on October 28, 2005, 05:42:26 PM
If I had just copy and pasted your code I would have decreased the readability of the source code dramatically, which just isn't an option when I probably won't personally be porting that module anyway.
Title: What is wrong with Numgils new plasment control?
Post by: Botsareus on October 28, 2005, 05:48:00 PM
And you are saying the code before was more readable? I dont think so...


Quote
YOU COULD OF EVEN TALKED TO ME ABOUT YOUR CODE, SO I COULD OF WROTE A COMPROMISE VIRSION. BUT IN REALITY THERE IS NOTHING TO COMPROMISE ABOUT, lets review:

Drag instead of Draw - sux
Move box outside screen - sux
Resize box outside screen -sux
No 8 point selection - sux
No clear indicators were the boarders of the plasment is (is it were the blue squars end , or when the gray nightmear ends) -sux (It is supposed to be messured by the middle of each blue square)

BLUE SQUARS ARE NICE N BIG -sux
Not to mention all the new features...

This thing goes litteraly agenst everything I had in mind. And then you call me a pill and say I should not act like I know you done that on purpose?

reply to that one.

Quote
It WAS NOT about HA! I CAN NOT READ YOUR CODE , THERE FOR I DON'T ADD IT. [you]because you could of just asked me.[/you]

reply to that one.



Tell me what is your next move, because you seam to be completly unprodicatble like Yankee. Thats the nature of the problem.
Title: What is wrong with Numgils new plasment control?
Post by: Numsgil on October 28, 2005, 05:49:09 PM
No, I'm saying the code now is more readable.
Title: What is wrong with Numgils new plasment control?
Post by: Botsareus on October 28, 2005, 05:53:07 PM
What part of my code is not readable, to the same thing that the bug fix people are doing, quote parts of my code and I will tell you what they do. Then you can comment the bugizes out of it, or rewrite the same thing in a -Numgilfied matter.

and while you are at it see
http://forum.darwinbots.com/index.php?show...dpost&p=1126054 (http://forum.darwinbots.com/index.php?showtopic=909&view=findpost&p=1126054)
because I am starting to get "lazy" making quotes...
Title: What is wrong with Numgils new plasment control?
Post by: Numsgil on October 28, 2005, 06:19:09 PM
I'm sort of rushing at the moment, so I can't go into it thoroughly.

Basically (strictly style-wise)

undescriptive variable names
no indenting (maybe you did a little, but far too sparsely)
use of functions when a switch case would have been more effective

to name a few.

And I like the way mine handles more than the way yours handles.  I was disatisfied.  I liked the idea of the original controls, it just needed to be done better.

I was running low on time, so I didn't code any hard limits to the various boxes as to where they could and could not (such as out of bounds) and I was going to add some lines that could be drug, and have the blue boxes dissapear if the height or width became too narrow.

But it all takes time and I'm porting to C++, using an entirely new GUI so it seemed sort of a waste.
Title: What is wrong with Numgils new plasment control?
Post by: Ulciscor on October 28, 2005, 07:28:08 PM
This is ridiculous.

[Bots] if you prefer your method then why not keep developing it, improving on the observations [Num] has made. Since he is busy switching the code over, I'm sure it would be appreciated if you could improve upon the code and submit it to him to check, if he has the time.

[Num] or [PY] don't expect fanfares and threads writing their hearty congratulations every time they make a change. If you can't take criticism about your code or debate about it in a calm manner, then the issue won't be solved and people will end up hot and bothered.

If you and [Num] still disagree on the coding front, then I think it would be fair to allow your version to be given as an option for people to choose.
Title: What is wrong with Numgils new plasment control?
Post by: Old Henk on October 29, 2005, 04:51:02 AM
Ah well, at least these dead-end discussions are fun to read through...  :rolleyes:

BTW I second Nums on this.