Author Topic: Fixed Console Crash in 2.4A  (Read 3949 times)

Offline EricL

  • Administrator
  • Bot God
  • *****
  • Posts: 2266
    • View Profile
Fixed Console Crash in 2.4A
« on: March 19, 2006, 02:23:41 PM »
This was bugging me so I fixed it.  2.4A crashes with an error '91' if you attempt to execute a command in a console window that was opened on a bot that has since died.  The routine evnt_textentered() in console.frm did not check whether the robot's console was still valid.  I added a check (line 173 in console.frm).

Additionally, I added a line in KillRobot() in robots.bas to indicate in the console window when the robot for that console has died.   (line 1461 in robots.bas).

Source modules attached.  To find changes, search for the string 'EricL'.

-E
« Last Edit: March 19, 2006, 02:26:06 PM by EricL »
Many beers....

Offline Numsgil

  • Administrator
  • Bot God
  • *****
  • Posts: 7742
    • View Profile
Fixed Console Crash in 2.4A
« Reply #1 on: March 19, 2006, 02:28:13 PM »
Good work.  When you finish to your own satisfaction I'll help you put together an official release.

Offline Griz

  • Bot Overlord
  • ****
  • Posts: 608
    • View Profile
Fixed Console Crash in 2.4A
« Reply #2 on: March 19, 2006, 02:38:03 PM »
great.
now, this robots.bas then includes the Gene activation fix as well, yes?
so I can overwrite it with this robots.bas?

was that
Public MaxMem As Integer
                           ' EricL March 15, 2006

just checking so I don't do the 'fixes' in the wrong order
once I find time to add them all.

I will also try to revive one of the old pages at the wiki ...
to keep track of the 'unoffical' bug fixes we add ...
so if someone runs into a problem they will be documented
in one place, with a timeline.
不知
~griz~
[/color]
   "The selection of Random Numbers is too important to be left to Chance"
The Mooj  a friend to all humanity
[/color]

Offline EricL

  • Administrator
  • Bot God
  • *****
  • Posts: 2266
    • View Profile
Fixed Console Crash in 2.4A
« Reply #3 on: March 19, 2006, 02:56:40 PM »
Thanks Nums.  I was planning on sending you some mail to see how I could best be of help.

If the C++ version isn't imminient, then I think maybe for the next few weeks, I'll keep patching 2.4 as I come up to speed on DB, drop a 2.4B, fixing the things that were broken since 2.37.6 and working towards that being the stable VB platform so people can get off of 2.37.6.  With one exception, I've no inclination to do any new feature work in VB, just maybe fix leagues and internet sharing.  Maybe.  I'm thinking a few weeks max as I explore and come up to speed.  (The one exception is maybe some experimentation on codon-level encoidng for in-genome mutation probability.  Still owe a proposal on that.)

After that, I'll switch over to helping out on the C++ fork and ping you for some work items at that time.  I have it building now, but have some link errors I need to dig into.  I'll send separate mail on that.

-E
Many beers....

Offline EricL

  • Administrator
  • Bot God
  • *****
  • Posts: 2266
    • View Profile
Fixed Console Crash in 2.4A
« Reply #4 on: March 19, 2006, 03:01:04 PM »
Griz:  Yes, this robots.bas includes the gene activation fix.  You can cut and paste fixes individually if you want, they are pretty independent of one another -  or it might just be easier to drop the entire file over the other and build, unless you have made private fixes yourself in which case you will need to merge by hand.

Cheers,

-E
Many beers....

Offline Griz

  • Bot Overlord
  • ****
  • Posts: 608
    • View Profile
Fixed Console Crash in 2.4A
« Reply #5 on: March 19, 2006, 03:04:47 PM »
here's the Bug Report/Fix page at the wiki:
http://www.darwinbots.com/WikiManual/index...tle=Bug_Reports

the intention is to provide a central location with a chronological
record of the unofficial bug fixes we are finding ...
prior to a new Official version of 2.37.6 or 2.4.A coming out
with the fixes included.

I am pressed for time right now ...
will replace what's there with the new stuff Eric has found asap.
anyone who wants to help or has a better way to do it is certainly
welcome to do so.
ideally, we would update this page as they are found/fixed ...
so we don't have to go back searching thru the threads here
at the forum to find all the info again.
links can also be provided at the wiki ...
to the uploaded files here ...
ie ... like Eric's robot.bas with the changes.

m thinking is ...
it would be nice to do these fixes in an orderly fashion ...
where one and all can access them as they come onboard.

the 'search function' here at the forum ...
leaves something to be disired. ;)
the search at the wiki works pretty good.
不知
~griz~
[/color]
   "The selection of Random Numbers is too important to be left to Chance"
The Mooj  a friend to all humanity
[/color]

Offline Numsgil

  • Administrator
  • Bot God
  • *****
  • Posts: 7742
    • View Profile
Fixed Console Crash in 2.4A
« Reply #6 on: March 19, 2006, 03:14:13 PM »
The C++ version has maybe a man month of effort left.  The problem is that all that's left are things I've specifically put off doing bcause I either don't want to do them or don't know how.

Like the bot debugging tools that are essential to track down errors.  Ugh.  And the ability to click-select a bot.  I have no idea how to code that.

Maybe you can help me debug the C++ version when it comes to that.

Offline Griz

  • Bot Overlord
  • ****
  • Posts: 608
    • View Profile
Fixed Console Crash in 2.4A
« Reply #7 on: March 19, 2006, 03:33:43 PM »
Quote
Maybe you can help me debug the C++ version when it comes to that.
sure.
meanwhile, this is all good practice ...
and may still come in handy for those who currently want to fix some
stuff in 2.37.6 and 2.4.A so they can get on with playing. ;)
不知
~griz~
[/color]
   "The selection of Random Numbers is too important to be left to Chance"
The Mooj  a friend to all humanity
[/color]

Offline Numsgil

  • Administrator
  • Bot God
  • *****
  • Posts: 7742
    • View Profile
Fixed Console Crash in 2.4A
« Reply #8 on: March 19, 2006, 05:00:56 PM »
I would like 2.4 to work.  I put alot of effort into it, I just got disgusted and frustrated that bugs kept popping up.

Offline Griz

  • Bot Overlord
  • ****
  • Posts: 608
    • View Profile
Fixed Console Crash in 2.4A
« Reply #9 on: March 19, 2006, 05:11:37 PM »
Quote
I would like 2.4 to work.  I put alot of effort into it, I just got disgusted and frustrated that bugs kept popping up.
well, hopefully Eric will keep on sniffing them out ...
I'll work at documenting them so others can have a place to see just what
was done and how, to alter their own programs and  then perhaps become
interested enough again to use those versions and help us find more bugs.
and in the process, perhaps become interested in some of the programming ...
be it VB or C++.
at some point when things look like their working pretty well ...
and we've found most of them ...
maybe we can put out a new official version of 2.37.7 and 2.4.B.
不知
~griz~
[/color]
   "The selection of Random Numbers is too important to be left to Chance"
The Mooj  a friend to all humanity
[/color]